add checks to checkDesign process
Add checks to make sure there are no spaces or extra lines in design file.
No child items are currently assigned. Use child items to break down this issue into smaller parts.
Link issues together to show that they're related or that one is blocking others. Learn more.
When this merge request is accepted, this issue will be closed automatically.
Activity
- Gervaise Henry assigned to @ghenry
assigned to @ghenry
- Gervaise Henry changed milestone to %v2.1.5
changed milestone to %v2.1.5
- Gervaise Henry added bug enhancement labels
added bug enhancement labels
- Maintainer
@venkat.malladi can you give advice on this please... it is a try to fix the problem, or error out with an explanation question.
It is in checkDesign... @s181385 had an extra space at the end of the input design file... which checkDesign.py when writing into design.checked.csv converted into a new blank line... which cellranger mkfastq threw an error:
[error] Formatting error in sample sheet
I can do a check for spaces in any of the fields in the inputted design file (also blank spaces)... but the question is, do I remove spaces, or if detected cause an error that lets the user fix the issue themselves?
- Owner
@ghenry I say remove trailing spaces in a column using .str.strip()
- Gervaise Henry assigned to @s189701 and unassigned @ghenry
- Jeremy Mathews mentioned in commit c43e5767
mentioned in commit c43e5767
- Jeremy Mathews mentioned in merge request !54 (merged)
mentioned in merge request !54 (merged)
- Gervaise Henry closed via merge request !54 (merged)
closed via merge request !54 (merged)
- Jeremy Mathews closed via commit c43e5767
closed via commit c43e5767
- Gervaise Henry mentioned in commit 43e8ca42
mentioned in commit 43e8ca42